Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client auto-build for Windows machines #171

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

simonbethke
Copy link
Contributor

If no .nodenv/bin is found, try .nodeenv/Scripts

@brentyi
Copy link
Collaborator

brentyi commented Feb 8, 2024

Thanks @simonbethke! Do you know how this relates to #149?

@brentyi
Copy link
Collaborator

brentyi commented Feb 26, 2024

(to hold myself accountable: I got Parallels running on my Mac, so I can test this on Windows now! will do after ~March 8)

@brentyi brentyi changed the title On windows .nodeenv has no "bin" folder. Thus the example setup doesn't work. Fix client auto-build for Windows machines Mar 23, 2024
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simonbethke!!

@brentyi brentyi merged commit 20d7d88 into nerfstudio-project:main Mar 23, 2024
12 checks passed
@brentyi brentyi mentioned this pull request Mar 23, 2024
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
* If no .nodenv/bin is found, try .nodeenv/Scripts

* (WIP) fixes for autobuild on Windows

* Fix for POSIX systems

---------

Co-authored-by: root <root@Desktop-Simon>
Co-authored-by: Brent Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants